Hi Krzysztof, On Tue, Nov 28, 2023 at 3:32 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 28/11/2023 11:32, Geert Uytterhoeven wrote: > > On Tue, Nov 28, 2023 at 10:51 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >> On 26/11/2023 00:28, Niklas Söderlund wrote: > >>> Compatibles can come in two formats. Either "vendor,ip-soc" or > >>> "vendor,soc-ip". Add a DT schema file documenting Renesas preferred > >>> policy and enforcing it for all new compatibles, except few existing > >>> patterns. > >>> > >>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > > >>> + # Legacy namings - variations of existing patterns/compatibles are OK, > >>> + # but do not add completely new entries to these: > >>> + - pattern: "^renesas,can-[a-z0-9]+$" [ deleted 40 legacy patterns] > >> No, wait, you basically listed most of the SoC as exceptions. What SoC > >> blocks exactly are you going to cover in such case with your rules? > > > > As Renesas was an early adopter of DT, there are a lot of compatible > > values that do not follow current best practices. > > Unfortunately there is not much we can do about that... > > Hm, ok, given how many exceptions you have, just please consider whether > this schema will be of any use. IOW, how many of new SoC blocks you have > which are not covered by the exceptions? Given a modern SoC hardware manual contains +200 sections, there are still lots of opportunities for new SoC block bindings and drivers... We really do not want any new compatible values of the legacy form. I guess the TI people could use a schema to reject new non-standard compatible values, too: https://lore.kernel.org/all/CAMuHMdUYOq=q1j=d+Eac28hthOUAaNUkuvxmRu-mUN1pLKq69g@xxxxxxxxxxxxxx/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
