On Tue, Nov 14, 2023 at 05:40:20PM +0000, Conor Dooley wrote: > On Mon, Nov 13, 2023 at 09:19:02PM +0800, Chen Wang wrote: > > From: Chen Wang <unicorn_wang@xxxxxxxxxxx> > > > > Add documentation to describe Sophgo System Controller Registers for > > SG2042. > > > > Signed-off-by: Chen Wang <unicorn_wang@xxxxxxxxxxx> > > --- > > .../soc/sophgo/sophgo,sg2042-syscon.yaml | 38 +++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-syscon.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-syscon.yaml b/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-syscon.yaml > > new file mode 100644 > > index 000000000000..829abede4fd5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-syscon.yaml > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/sophgo/sophgo,sg2042-syscon.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sophgo SG2042 SoC system controller > > + > > +maintainers: > > + - Chen Wang <unicorn_wang@xxxxxxxxxxx> > > + > > +description: > > + The Sophgo SG2042 SoC system controller provides register information such > > + as offset, mask and shift to configure related modules. > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - sophgo,sg2042-syscon > > + - const: syscon > > THere's only one option here, so the oneOf should be removed. Similarly, > since there's only one SoC, and it sounds like the next large sophgo > system is going to be using an entirely different core provider, I think > should just simplify this to a pair of "const:" entries. For a simple syscon binding like this, you can just add the compatible to syscon.yaml. Rob
