On Wed, Nov 01, 2023 at 10:00:15AM +0000, Sakari Ailus wrote: > On Wed, Nov 01, 2023 at 11:50:00AM +0200, Andy Shevchenko wrote: > > On Wed, Nov 01, 2023 at 09:27:29AM +0200, Sakari Ailus wrote: ... > > > - Use size_t type for len. > > > > Strictly speaking it should be ptrdiff_t according to the code. > > It'll be compared to size_t right after. ptrdiff_t is signed and we know we > have a positive number here so size_t seems like a better choice. Yeah, this is downsides of C language and typing system. But diff between pointers returns ptrdiff_t result. ... > > > + * the comparison to either '\0' or '@' character > > > > NUL is a human-readable substitution to less parsable '\0'. > > I can send v3 with that but I'll wait a bit if there are more comments. Why not? You got tags, so I'll give mine with this being addressed. -- With Best Regards, Andy Shevchenko
