Re: [PATCH v2 1/1] device property: Add fwnode_name_eq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 01, 2023 at 11:50:00AM +0200, Andy Shevchenko wrote:
> On Wed, Nov 01, 2023 at 09:27:29AM +0200, Sakari Ailus wrote:
> > Add fwnode_name_eq() to implement the functionality of of_node_name_eq()
> > on fwnode property API. The same convention of ending the comparison at
> > '@' (besides '\0') is applied on also both ACPI and swnode. The function
> > is intended for comparing unit address-less node names on DT and firmware
> > or swnodes compliant with DT bindings.
> 
> ...
> 
> > - Use size_t type for len.
> 
> Strictly speaking it should be ptrdiff_t according to the code.

It'll be compared to size_t right after. ptrdiff_t is signed and we know we
have a positive number here so size_t seems like a better choice.

> 
> ...
> 
> > + * the comparison to either '\0' or '@' character
> 
> NUL is a human-readable substitution to less parsable '\0'.

I can send v3 with that but I'll wait a bit if there are more comments.

-- 
Sakari Ailus




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux