Hi Rob, On Tue, Oct 31, 2023 at 12:05:25PM -0500, Rob Herring wrote: > On Mon, Oct 30, 2023 at 03:32:45PM +0200, Laurent Pinchart wrote: > > From: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> > > > > The THP7312 is an external ISP from THine. Add DT bindings for it. > > > > Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx> > > Co-developed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > --- > > Changes since v4: > > > > - Add bus-type property > > > > Changes since v2: > > > > - Drop description of reg property > > - Improve thine,boot-mode property documentation > > - Making thine,boot-mode property optional > > - Don't use underscores in supplies names > > --- > > .../bindings/media/i2c/thine,thp7312.yaml | 231 ++++++++++++++++++ > > MAINTAINERS | 7 + > > 2 files changed, 238 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml > > new file mode 100644 > > index 000000000000..a576a8669644 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml > > @@ -0,0 +1,231 @@ [snip] > > + sensors: > > + type: object > > + description: List of connected sensors > > + > > + properties: > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > + > > + patternProperties: > > + "^sensor@[01]": > > Missing a '$' on the end. > > > + type: object > > + description: > > + Sensors connected to the first and second input, with one node per > > + sensor. > > + > > + properties: > > + thine,model: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: > > + Model of the connected sensors. Must be a valid compatible string. > > + > > + reg: > > + maxItems: 1 > > + description: THP7312 input port number > > items: > - maximum: 1 > > > + > > + data-lanes: > > + $ref: /schemas/media/video-interfaces.yaml#/properties/data-lanes > > + items: > > + maxItems: 4 > > + description: > > + This property is for lane reordering between the THP7312 and the imaging > > + sensor that it is connected to. > > + > > + patternProperties: > > + ".*-supply": > > "-supply$" > > > + description: Power supplies for the sensor > > Perhaps some reasoning why any supply name is allowed here? I've asked for more information about power supply sequencing, I have hopes I will be able to simplify all this. If I can't I'll expand the description. The idea is that the power supply names are specific to each sensor. I can try to specify them with conditional rules if that's preferred. > > + > > + required: > > + - reg > > + - data-lanes > > + > > + additionalProperties: false > > + > > + required: > > + - "#address-cells" > > + - "#size-cells" > > + > > + additionalProperties: false [snip] -- Regards, Laurent Pinchart
