On Wed, Nov 01, 2023 at 08:44:22PM +0300, Dmitry Rokosov wrote: > Hello Conor, > > On Wed, Nov 01, 2023 at 04:17:14PM +0000, Conor Dooley wrote: > > On Wed, Nov 01, 2023 at 11:04:16AM -0500, Rob Herring wrote: > > > > > > On Wed, 01 Nov 2023 17:24:45 +0300, Dmitry Rokosov wrote: > > > > AW200XX controllers have the capability to declare more than 0xf LEDs, > > > > therefore, it is necessary to accept LED names using an appropriate > > > > regex pattern. > > > > > > > > The register offsets can be adjusted within the specified range, with > > > > the maximum value corresponding to the highest number of LEDs that can > > > > be connected to the controller. > > > > > > > > Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx") > > > > Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxxxxx> > > > > --- > > > > .../bindings/leds/awinic,aw200xx.yaml | 64 +++++++++++++++++-- > > > > 1 file changed, 58 insertions(+), 6 deletions(-) > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@0: Unevaluated properties are not allowed ('reg' was unexpected) > > > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@1: Unevaluated properties are not allowed ('reg' was unexpected) > > > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@2: Unevaluated properties are not allowed ('reg' was unexpected) > > > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# > > > > Looks like you need to drop the second part of this hunk from the patch. > > @@ -45,17 +45,12 @@ properties: > > maxItems: 1 > > > > patternProperties: > > - "^led@[0-9a-f]$": > > + "^led@[0-9a-f]+$": > > type: object > > $ref: common.yaml# > > unevaluatedProperties: false > > > > properties: > > - reg: > > - description: > > - LED number > > - maxItems: 1 > > - > > led-max-microamp: > > default: 9780 > > description: | > > > > Each LED still only has one reg entry, right? > > You're right... the maxItems for 'reg' is still needed. I'll back it in > the next version. > But I don't understand, why my dt_binding_check run doesn't show me this > problem... I don't specify DT_CHECKER_FLAGS, maybe this is a root cause. I dunno! I do `make dt_binding_check W=1 DT_SCHEMA_FILES="$filename"` to test stuff. Also, you can keep the tag.
Attachment:
signature.asc
Description: PGP signature