Hello Krzystof, On Mon, 23 Oct 2023, Krzysztof Kozlowski wrote: [...] > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm IPQ4019 Ethernet switch subsystem driver > > Bindings should be about hardware. Please drop "driver". "Subsystem" > also sounds like Linuxism. The "driver" part was a mistake, I will drop it. However, the "subsystem" terminology seems relevant here, as the SoC documentation refers to this IP group as the "Ethernet Switch Subsystem". If it's okay with you, I'll change this to "Qualcomm IPQ4019 Ethernet Switch Subsystem (ESS)" in the v2. > > +properties: > > + compatible: > > + const: qca,ipq4019-qca8337n > > > What do you want to express here? ipq4019 is not qca. This is Qualcomm > (so qcom) SoC. Agreed, I'll change the compatible. Thanks, Romain
