On 23/10/2023 17:50, Romain Gantois wrote: > Add the DT binding for the IPQESS Ethernet switch subsystem, that > integrates a modified QCA8K switch and an EDMA MAC controller. It inherits > from a basic ethernet switch binding and adds three regmaps, a phandle and > reset line for the PSGMII, a phandle to the MDIO bus, a clock, and 32 > interrupts. > > Signed-off-by: Romain Gantois <romain.gantois@xxxxxxxxxxx> > --- > .../bindings/net/qcom,ipq4019-ess.yaml | 152 ++++++++++++++++++ > 1 file changed, 152 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq4019-ess.yaml > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-ess.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-ess.yaml > new file mode 100644 > index 000000000000..9bb6b010ea6a > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-ess.yaml > @@ -0,0 +1,152 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/qcom,ipq4019-ess.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm IPQ4019 Ethernet switch subsystem driver Bindings should be about hardware. Please drop "driver". "Subsystem" also sounds like Linuxism. > + > +maintainers: > + - Romain Gantois <romain.gantois@xxxxxxxxxxx> > + > +$ref: ethernet-switch.yaml# > + > +properties: > + compatible: > + const: qca,ipq4019-qca8337n What do you want to express here? ipq4019 is not qca. This is Qualcomm (so qcom) SoC. > + > + reg: > + maxItems: 3 > + description: Base ESS registers, PSGMII registers and EDMA registers You need to describe the items, so: items: - description: foo - description: foo - description: foo > + > + reg-names: > + maxItems: 3 You need to list items instead. > + > + resets: > + maxItems: 2 > + description: Handles to the PSGMII and ESS reset lines You need to list items instead. > + > + reset-names: > + maxItems: 2 You need to list items instead. > + > + clocks: > + maxItems: 1 > + description: Handle to the GCC ESS clock > + > + clock-names: > + maxItems: 1 Drop clock-names, useless for one entry. > + > + psgmii-ethphy: > + maxItems: 1 > + description: Handle to the MDIO bus node corresponding to the PSGMII That's a bit odd property. Where is it defined? > + > + mdio: > + maxItems: 1 > + description: Handle to the IPQ4019 MDIO Controller > + > + interrupts: > + maxItems: 32 > + description: One interrupt per tx and rx queue, the first 16 are rx queues > + and the last 16 are the tx queues > + > +required: > + - compatible > + - reg > + - reg-names > + - resets > + - reset-names > + - clocks > + - clock-names > + - mdio > + - interrupts > + > +unevaluatedProperties: false Best regards, Krzysztof
