> > > -----Original Message----- > > > From: shh.xie@xxxxxxxxx [mailto:shh.xie@xxxxxxxxx] > > > Sent: Tuesday, December 23, 2014 3:58 PM > > > To: linuxppc-dev@xxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Wood > > > Scott-B07421 > > > Cc: Medve Emilian-EMMEDVE1; Xie Shaohui-B21989 > > > Subject: [PATCH] [v3] power/fsl: add MDIO dt binding for FMan > > > > > > From: Shaohui Xie <Shaohui.Xie@xxxxxxxxxxxxx> > > > > > > This binding is for FMan MDIO, it covers FMan v2 & FMan v3. > > > > > > Signed-off-by: Shaohui Xie <Shaohui.Xie@xxxxxxxxxxxxx> > > > --- > > > changes in v3: > > > rephrase the 'Definition' of property 'bus-frequency', don't include > > > the property in example. > > > > > > changes in v2: > > > addressed comments from Scott in V1. > > > > > > .../devicetree/bindings/powerpc/fsl/fman.txt | 69 > ++++++++++++++++++++++ > > > 1 file changed, 69 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > > > b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > > > index edeea16..737aa4c 100644 > > > --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt > > > @@ -7,6 +7,7 @@ CONTENTS > > > - FMan MURAM Node > > > - FMan dTSEC/XGEC/mEMAC Node > > > - FMan IEEE 1588 Node > > > + - FMan MDIO Node > > > - Example > > > > > > > > > ==================================================================== > > > ========= @@ -357,6 +358,69 @@ ptp-timer@fe000 { }; > > > > > > > > > ==================================================================== > > > ========= > > > +FMan MDIO Node > > > + > > > +DESCRIPTION > > > + > > > +The MDIO is a bus to which the PHY devices are connected. > > > + > > > +PROPERTIES > > > + > > > +- compatible > > > + Usage: required > > > + Value type: <stringlist> > > > + Definition: A standard property. > > > + Must include "fsl,fman-mdio" for 1 Gb/s MDIO from FMan v2. > > > + Must include "fsl,fman-xmdio" for 10 Gb/s MDIO from FMan v2. > > > + Must include "fsl,fman-memac-mdio" for 1/10 Gb/s MDIO from > > > + FMan v3. > > > + > > > +- reg > > > + Usage: required > > > + Value type: <prop-encoded-array> > > > + Definition: A standard property. > > > + > > > +- bus-frequency > > > + Usage: optional > > > + Value type: <u32> > > > + Definition: Specifies the external MDIO bus clock speed to > > > + be used, if different from the standard 2.5 MHz. > > > + This may be due to the standard speed being unsupported (e.g. > > > + due to a hardware problem), or to advertise that all relevant > > > + components in the system support a faster speed. > > > + > > > +- interrupts > > > + Usage: optional > > > + Value type: <prop-encoded-array> > > > + Definition: Event interrupt of external MDIO controller. > > > + 1 Gb/s MDIO and 10 Gb/s MDIO has one interrupt respectively. > > I'm confused by "respectively" here. Does fsl,fman-memac-mdio have two > interrupts (one for 1 Gb/s and one for 10 Gb/s)? [S.H] We use two MDIO controllers for external PHY management. One for 1 Gb/s, One for 10 Gb/s, and two MDIO interrupts connected to MPIC. If there's only (at > most) one interrupt per MDIO controller then just delete this line. > > What interrupt is used for internal MDIO? [S.H] internal MDIO has no interrupt. Does "optional" mean it's used if and > only if external MDIO is used, or is it optional even with external MDIO? I see > it's not present in the example -- do we not have a real example that has the > interrupt? [S.H] "optional" means it's available on hardware, but MDIO driver does not use interrupt. So we don't have a real example. Thanks! Shaohui ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
