On Fri, Oct 6, 2023 at 7:05 PM Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxxxxx> wrote: > > From: George Stark <gnstark@xxxxxxxxxxxxxxxxx> > > use DIV_ROUND_UP instead of coarse div Please, respect English grammar and punctuation. Refer to macros and functions as func() (note the parentheses). ... > #define AW200XX_REG_DIM2FADE(x) ((x) + 1) > +#define AW200XX_REG_FADE2DIM(fade) \ > + DIV_ROUND_UP((fade) * AW200XX_DIM_MAX, AW200XX_FADE_MAX) Have you checked if the overflow is _now_ possible (compiling on 32-bit platforms as well)? -- With Best Regards, Andy Shevchenko