On 20/09/2023 16:25, Liviu Dudau wrote:
> On Wed, Sep 20, 2023 at 03:51:36PM +0200, Krzysztof Kozlowski wrote:
>> On 20/09/2023 15:41, Liviu Dudau wrote:
>>>>> +properties:
>>>>> + $nodename:
>>>>> + pattern: '^gpu@[a-f0-9]+$'
>>>>> +
>>>>> + compatible:
>>>>> + oneOf:
>>>>
>>>> Drop oneOf.
>>>
>>> The idea was to allow for future compatible strings to be added later, but
>>> I guess we can re-introduce the oneOf entry later. Will remove it.
>>
>> If you already predict that new list will be added (so new fallback
>> compatible!), then it's fine.
>>
>>>
>>>>
>>>>> + - items:
>>>>> + - enum:
>>>>> + - rockchip,rk3588-mali
>>>>> + - const: arm,mali-valhall-csf # Mali Valhall GPU model/revision is fully discoverable
>>>>> +
>>>>> + reg:
>>>>> + maxItems: 1
>>>>> +
>>>>> + interrupts:
>>>>> + items:
>>>>> + - description: Job interrupt
>>>>> + - description: MMU interrupt
>>>>> + - description: GPU interrupt
>>>>> +
>>>>> + interrupt-names:
>>>>> + items:
>>>>> + - const: job
>>>>> + - const: mmu
>>>>> + - const: gpu
>>>>> +
>>>>> + clocks:
>>>>> + minItems: 1
>>>>> + maxItems: 3
>>>>> +
>>>>> + clock-names:
>>>>> + minItems: 1
>>>>> + items:
>>>>> + - const: core
>>>>> + - const: coregroup
>>>>> + - const: stacks
>>>>> +
>>>>> + mali-supply: true
>>>>> +
>>>>> + sram-supply: true
>>>>> +
>>>>> + operating-points-v2: true
>>>>
>>>> Missing opp-table.
>>>
>>> This is the main topic I want to clarify. See further down for the main comment,
>>> but I would like to understand what you are asking here. To copy the schema
>>> from bindings/opp/opp-v2.yaml and bindings/opp/opp-v2-base.yaml?
>>
>> No, "opp-table" property.
>> git grep "opp-table:"
>
> You mean adding
>
> opp-table:
> type: object
>
> as property? What's the difference between opp-table: true (like in
> 'display/msm/dp-controller.yaml') and 'opp-table: type: object' like in other
There is no opp-table: true. Nowhere.
...
>>>
>>>>
>>>>> + };
>>>>> +
>>>>> + gpu_opp_table: opp-table {
>>>>
>>>> Opp table should be inside the device node.
>>>
>>> I cannot find any device tree that supports your suggested usage. Most (all?) of
>>
>> Really? All Qcom have it embedded.
>
> The arm,mali-* ones seem to have them outside the gpu node. See "arm,mali-midgard.yaml"
You said you cannot find any, so I pointed out that's not true.
Best regards,
Krzysztof
