Hi Mark, On Tue, Sep 19, 2023 at 8:38 PM Chun-Jen Tseng (曾俊仁) <Chun-Jen.Tseng@xxxxxxxxxxxx> wrote: > > On Tue, 2023-09-19 at 12:52 +0200, AngeloGioacchino Del Regno wrote: > > Il 19/09/23 03:44, Mark Tseng ha scritto: > > > MT8188 svs gpu uses 2-line high bank and low bank to optimize the > > > voltage of opp table for higher and lower frequency respectively. > > > > > > Signed-off-by: Mark Tseng <chun-jen.tseng@xxxxxxxxxxxx> > > > --- <snip> > > > + > > > + /* For voltage bin support */ > > > > I already asked you to please send the voltage bin support as a > > separated commit > > because this is for *all SoCs* and not only for 8188. > > > > Again, please separate the voltage bin support from the MT8188 > > support. > > > Hi Angelo, > > I have already checked "voltage bins turn point" with DE, it is support > for *all SoCs* , not only for MT8188. I think Angelo's point is that you should separate this patch into two, where: - "soc: mediatek: svs: Add support for voltage bins" contains changes only related to the "For voltage bin support" part. - "soc: mediatek: svs: Add support for MT8188 SoC" contains code that is specifically for MT8188, i.e. svs_mt8188_efuse_parsing, svs_mt8188_banks etc. It'd be easier for people to review, manage and cherry-pick patches if you add the generic changes apart from the platform-specific code. For example, someone will be able to simply pick up the patch for voltage bin support solely if they are not interested in MT8188. Regards, Fei > > > > soc: mediatek: svs: Add support for voltage bins > > soc: mediatek: svs: Add support for MT8188 SoC > > > > Regards, > > Angelo > >
