On 14/09/2023 09:00, Huqiang Qin wrote: > Hi Krzysztof, > > On 2023/9/14 14:16, Krzysztof Kozlowski wrote: > ... >>> diff --git a/include/dt-bindings/gpio/amlogic-t7-gpio.h b/include/dt-bindings/gpio/amlogic-t7-gpio.h >>> new file mode 100644 >>> index 000000000000..2bab9a99501a >>> --- /dev/null >>> +++ b/include/dt-bindings/gpio/amlogic-t7-gpio.h >> >> Use compatible syntax. > > The amlogic-t7-gpio.h is not a file in the dt-bindings/pinctrl/ directory. > Does it also need to be named according to the compatible name of pinctrl? The convention, which we introduced since ~1-2 years, is to use the device compatible or binding filename as the headers filename. Now, where you put what does not affect it. Best regards, Krzysztof
