Hi Krzysztof, On 2023/9/14 14:16, Krzysztof Kozlowski wrote: ... >> diff --git a/include/dt-bindings/gpio/amlogic-t7-gpio.h b/include/dt-bindings/gpio/amlogic-t7-gpio.h >> new file mode 100644 >> index 000000000000..2bab9a99501a >> --- /dev/null >> +++ b/include/dt-bindings/gpio/amlogic-t7-gpio.h > > Use compatible syntax. The amlogic-t7-gpio.h is not a file in the dt-bindings/pinctrl/ directory. Does it also need to be named according to the compatible name of pinctrl? > >> @@ -0,0 +1,179 @@ >> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */ >> +/* >> + * Copyright (c) 2023 Amlogic, Inc. All rights reserved. >> + * Author: Huqiang Qin <huqiang.qin@xxxxxxxxxxx> >> + */ >> + >> +#ifndef _DT_BINDINGS_AMLOGIC_T7_GPIO_H >> +#define _DT_BINDINGS_AMLOGIC_T7_GPIO_H >> + >> +#define GPIOB_0 0 > > Why weird indentation? Okay, I didn't observe it, thanks for pointing it out. ... Best regards, Huqiang Qin
