On 14/09/2023 07:45, Huqiang Qin wrote: > Add a new compatible name for Amlogic T7 pin controller, and add > a new dt-binding header file which document the detail pin names. > > Signed-off-by: Huqiang Qin <huqiang.qin@xxxxxxxxxxx> > --- > .../pinctrl/amlogic,meson-pinctrl-a1.yaml | 1 + > include/dt-bindings/gpio/amlogic-t7-gpio.h | 179 ++++++++++++++++++ > 2 files changed, 180 insertions(+) > create mode 100644 include/dt-bindings/gpio/amlogic-t7-gpio.h > > diff --git a/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml > index 4e7a456ea4cc..c7df4cd34197 100644 > --- a/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/amlogic,meson-pinctrl-a1.yaml > @@ -16,6 +16,7 @@ properties: > compatible: > enum: > - amlogic,c3-periphs-pinctrl > + - amlogic,t7-periphs-pinctrl > - amlogic,meson-a1-periphs-pinctrl > - amlogic,meson-s4-periphs-pinctrl > > diff --git a/include/dt-bindings/gpio/amlogic-t7-gpio.h b/include/dt-bindings/gpio/amlogic-t7-gpio.h > new file mode 100644 > index 000000000000..2bab9a99501a > --- /dev/null > +++ b/include/dt-bindings/gpio/amlogic-t7-gpio.h Use compatible syntax. > @@ -0,0 +1,179 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */ > +/* > + * Copyright (c) 2023 Amlogic, Inc. All rights reserved. > + * Author: Huqiang Qin <huqiang.qin@xxxxxxxxxxx> > + */ > + > +#ifndef _DT_BINDINGS_AMLOGIC_T7_GPIO_H > +#define _DT_BINDINGS_AMLOGIC_T7_GPIO_H > + > +#define GPIOB_0 0 Why weird indentation? Best regards, Krzysztof