> -----Original Message----- > From: Wood Scott-B07421 > Sent: Tuesday, December 23, 2014 4:08 PM > To: Xie Shaohui-B21989 > Cc: Medve Emilian-EMMEDVE1; linuxppc-dev@xxxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; Liberman Igal-B31950 > Subject: Re: [PATCH] [v2] power/fsl: add MDIO dt binding for FMan > > On Tue, 2014-12-23 at 01:35 -0600, Xie Shaohui-B21989 wrote: > > +- bus-frequency > > + Usage: optional > > + Value type: <u32> > > + Definition: Specifies external MDIO bus clock speed which is > > + different from MDIO standard 2.5MHz. Should be defined for > SoCs > > + on which the standard one cannot work. > > > > What should I rephrase it? Replace the last sentence with "Should be > > defined For SoCs on which a lower frequency than the standard is > required."? > > Neither of these work with Emil's scenario of a system that allows a > faster-than-standard speed. > > How about: "Definition: Specifies the external MDIO bus clock speed to be > used, if different from the standard 2.5 MHz. This may be due to the > standard speed being unsupported (e.g. due to a hardware problem), or to > advertise that all relevant components in the system support a faster > speed." [S.H] OK. I'll use this in V3. > > > How about the value used in example? > > Should 2.5MHz be used or a lower one? > > If you don't have a realistic example to use, don't put it in the example > at all. 2.5MHz is the worst example to use because that's the default > and there'd be no reason to use the property at all. [S.H] OK. The V3 will not have this in example. Thank you all for reviewing! Shaohui ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f