Re: [PATCH v5 1/2] dt-bindings: arm64: dts: mediatek: add mt8395-evk board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/11/23 14:07, Krzysztof Kozlowski wrote:
	

External email : Please do not click links or open attachments until you have verified the sender or the content.

On 10/09/2023 14:23, Macpaul Lin wrote:


On 9/10/23 18:56, Krzysztof Kozlowski wrote:


External email : Please do nost click links or open attachments until you have verified the sender or the content.

On 09/09/2023 15:28, Macpaul Lin wrote:
1. Add compatible for MT8395.
2. Add bindings for the MediaTek mt8395-evk board, also known
as the "Genio 1200-EVK".

The MT8195 and MT8395 belong to the same SoC family,
with only minor differences in their physical characteristics.
They utilize unique efuse values for differentiation.

The booting process and configurations are managed by boot
loaders, firmware, and TF-A. Consequently, the part numbers
and procurement channels vary.

Signed-off-by: Macpaul Lin <macpaul.lin@xxxxxxxxxxxx>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Changes for v4:
Changes for v5:
  - No change, update Reviewed-by tag only. Thanks.

The explanation is here. The version v4 and v5 are the same.
For sending v5 is because "Patch v5 2/2" has been updated and these 2 patches were in the same patch set. I think to update the whole patch set together with a single modified patch should be a usual operation.
Did I miss anything?

Yeah, like not top-posting.

Why do you change the same line in other patchset?

Hmm, they are different patch actually.
I've tested the patch v5 here can be applied with / without mt8365's description patch independently.
I'm not sure why the patch show the patch started from the same line number.
@@ -248,7 +248,8 @@ properties:
But these 2 patch sets seems won't be conflict at my local.


Confusing. You just sent a patch changing the same hunk - adding
description, without any explanation.


The marketing naming rule of MediaTek SOCs are usually confusing people. I guess the previous patch just confused you. Ha.

?



Best regards,
Krzysztof


Thanks
Macpaul Lin



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux