On 10/08/2023 11:30, Sheng-Liang Pan wrote: > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >> Isn't this duplicated with r9? Probably other places as well... or.... >> separate r10 add rt5682s node which different with r9. > we separate r10 add rt5682s which differentwith r9 > > >>> - model = "Google Lazor Limozeen without Touchscreen (rev9+)"; >>> - compatible = "google,lazor-sku6", "google,lazor-sku18", "qcom,sc7180"; >>> + model = "Google Lazor Limozeen without Touchscreen (rev9)"; >>> + compatible = "google,lazor-rev9-sku6", "google,lazor-rev9-sku18", "qcom,sc7180"; > >> Your patch 2 does not make any sense. Didn't you touch it in patch 2? >> Really, what is happening here? > patch 2 explain why we added new sku for no-eSIM. So which commit explain why you touch the same line twice? Sorry, this does not make sense. Best regards, Krzysztof