On Mon, Aug 7, 2023 at 2:23 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 03/08/2023 09:42, Chen-Yu Tsai wrote: > > From: Zhiyong Tao <zhiyong.tao@xxxxxxxxxxxx> > > > > The MediaTek MT6366 PMIC is similar to the MT6358 PMIC. It is designed > > to be paired with the MediaTek MT8186 SoC. It has 9 buck regulators and > > 29 LDO regulators, not counting ones that feed internally and basically > > have no controls. The regulators are named after their intended usage > > for the SoC and system design, thus not named generically as ldoX or > > dcdcX, but as vcn33 or vgpu. > > > > Add a binding document describing all the regulators and their supplies. > > > > Signed-off-by: Zhiyong Tao <zhiyong.tao@xxxxxxxxxxxx> > > [wens@xxxxxxxxxxxx: major rework and added commit message] > > Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> > > --- > > Changes since Zhiyong's last version (v4) [1]: > > - simplified regulator names > > - added descriptions to regulators > > - removed bogus regulators (*_sshub) > > - merged vcn33-wifi and vcn33-bt as vcn33 > > - added missing regulators (vm18, vmddr, vsram-core) > > - cut down examples to a handful of cases and made them complete > > - expanded commit message a lot > > > > [1] https://lore.kernel.org/linux-arm-kernel/20220823123745.14061-1-zhiyong.tao@xxxxxxxxxxxx/ > > > > .../regulator/mediatek,mt6366-regulator.yaml | 154 ++++++++++++++++++ > > 1 file changed, 154 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > > > > diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > > new file mode 100644 > > index 000000000000..715c6ffcb3ab > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > > @@ -0,0 +1,154 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/regulator/mediatek,mt6366-regulator.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MT6366 Regulator from MediaTek Integrated > > + > > +maintainers: > > + - Zhiyong Tao <zhiyong.tao@xxxxxxxxxxxx> > > + > > +description: | > > + Regulator part of the MT6366 PMIC. This node should be under the PMIC's > > + device node. > > + > > +properties: > > + compatible: > > + const: mediatek,mt6366-regulator > > + > > + vsys_ldo1-supply: > > Don't use underscores in property names. Only hyphens, if needed. I assume that applies even if the actual name in the datasheet has underscores? Will change, but will wait on discussion on patch 3 before sending a new revision. ChenYu > > + description: Supply for LDOs vfe28, vxo22, vcn28, vaux18, vaud28, vsim1, vusb, vbif28 > > + vsys_ldo2-supply: > > > > Best regards, > Krzysztof >
