On 31/07/2023 10:29, Jai Luthra wrote: > Multiple TI SoCs (J721E, AM62) use this CSI2RX receiver, integrated with > an external DPHY and a pixel-grabber IP that unwraps the pixel data and > send it to memory via DMA. > > Add a separate compatible for the TI-specific version of this IP. > > Signed-off-by: Jai Luthra <j-luthra@xxxxxx> > --- > New in v8 > > drivers/media/platform/cadence/cdns-csi2rx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c > index 0d879d71d818..b087583d636f 100644 > --- a/drivers/media/platform/cadence/cdns-csi2rx.c > +++ b/drivers/media/platform/cadence/cdns-csi2rx.c > @@ -559,6 +559,7 @@ static void csi2rx_remove(struct platform_device *pdev) > > static const struct of_device_id csi2rx_of_table[] = { > { .compatible = "starfive,jh7110-csi2rx" }, > + { .compatible = "ti,j721e-csi2rx" }, Why do you need it? It's redundant - already compatible with cdns. No need to add empty match entries. > { .compatible = "cdns,csi2rx" }, > { }, Best regards, Krzysztof