On 02/08/2023 17:25, Conor Dooley wrote: > Hey, > > On Tue, Aug 01, 2023 at 08:40:47PM -0300, Fabio Estevam wrote: >> Add DT bindings for OmniVision OV5642 Image Sensor. >> >> Signed-off-by: Fabio Estevam <festevam@xxxxxxx> > > Thanks for doing this. It looks good to me, although I got a complaint > from git while applying it locally: > Applying: dt-bindings: trivial-devices: Remove the OV5642 entry > Applying: dt-bindings: media: Add OV5642 > /stuff/linux/.git/worktrees/linux-dt/rebase-apply/patch:119: trailing whitespace. > > warning: 1 line adds whitespace errors. > > I think you can probably squash both patches and add a Yes, they should be squashed, otherwise it is not really bisectable. Compatible disappears after first patch... and the first patch does not have any sense on its own. Even if this is not trivial device, removing it without documentation is not the way. Best regards, Krzysztof
