On 2.08.2023 11:59, Rohit Agarwal wrote: > Add the regulators found on SDX75 IDP. > > Signed-off-by: Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx> > --- [...] > + vreg_s2b_1p224: smps2 { Even though most RPMh devices use the schematic-like names, I think naming the labels like pmicname_regname, e.g. pm8550_l2 would be easier to read.. (Bjorn, Krzysztof - opinions?) On top of that, please add labels to all of the regulators you're introducing to limit unnecessary diff in the future. Konrad