Hi Krzysztof, > >>> + realtek,enable-l4icg: > >>> + description: Enable the power saving feature l4icg by hardware > clock. > >>> + gating. > >> > >> You described the desired Linux feature or behavior, not the actual > hardware. > >> The bindings are about the latter, so instead you need to rephrase > >> the property and its description to match actual hardware > >> capabilities/features/configuration etc. > > > > The l4icg entry is a hardware feature for power saving. > > The term may not clearly convey the function. > > So instead of the term "l4icg" I use "hw clock gating". > > > > realtek,enable-hw-clock-gating: > > description: Enable the clock gated function which will gating sram > > clock when dbus idle. > > And why this should be configurable per board? It looks you like to put OS > policy into DT, so no. > Ok, I'll remove it from DT. I put it in DT because hw-clock-gating is not an OS policy. This is a pure hardware function and is not controlled by software. I want to control enabling or disabling on different SoCs or boards. But for power saving, it should be enabled by default except for rtd1295 SoC. So I would handle this special case of rtd1295 in the driver. Thanks, Stanley
