> -----Original Message----- > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > Sent: Monday, July 24, 2023 12:18 PM > To: Pankaj Gupta <pankaj.gupta@xxxxxxx> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; Conor Dooley > <conor@xxxxxxxxxx>; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; > kernel@xxxxxxxxxxxxxx; clin@xxxxxxxx; conor+dt@xxxxxxxxxx; > pierre.gondois@xxxxxxx; Jacky Bai <ping.bai@xxxxxxx>; Clark Wang > <xiaoning.wang@xxxxxxx>; Wei Fang <wei.fang@xxxxxxx>; Peng Fan > <peng.fan@xxxxxxx>; Bough Chen <haibo.chen@xxxxxxx>; > festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; > davem@xxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > krzysztof.kozlowski+dt@xxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Gaurav Jain > <gaurav.jain@xxxxxxx>; alexander.stein@xxxxxxxxxxxxxxx; Sahil Malhotra > <sahil.malhotra@xxxxxxx>; Aisheng Dong <aisheng.dong@xxxxxxx>; Varun > Sethi <V.Sethi@xxxxxxx> > Subject: Re: [EXT] Re: [PATCH v4 1/7] dt-bindings: arm: fsl: add se-fw binding > doc > > On Mon, Jul 24, 2023 at 06:37:22AM +0000, Pankaj Gupta wrote: > > > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> On > > > 12/07/2023 20:26, Conor Dooley wrote: > > > > On Wed, Jul 12, 2023 at 05:42:13PM +0530, Pankaj Gupta wrote: > > > > >> + value, i.e., supported SoC(s) are imx8ulp, imx93. > > > > >> + > > > >> +properties: > > > >> + compatible: > > > >> + enum: > > > >> + - fsl,imx-ele > > > > > > > > This looks like a generic compatible, not a specific one, but you > > > > use it on the imx8ulp. I would have expected that you would have > > > > something like "fsl,imx8ulp-ele" for that. > > > > > > Yeah, this one looks generic, so not what we expect. > > > > This change left un-changed in V4. It is "fsl,se-fw", instead of "fsl,imx8ulp- > ele". > > I will change in V5. > > That's a generic compatible too, so no different to "fsl,imx-ele". > What is the reason for avoiding the SoC-specific "fsl,imx8ulp-ele"? Sorry. I missed this point. Not trying to avoid the SoC specific compatible. I will add the soc id to make the compatible = "fsl,se-8ulpfw", instead of "fsl,se-fw". Thanks for pointing out here. > > > > >> + - fsl,imx93-ele
