Re: RE: [PATCH v2 1/3] arm64: dts: imx93: add the Flex-CAN stop mode by GPR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26.07.2023 11:10:10, Bough Chen wrote:
> > >  arch/arm64/boot/dts/freescale/imx93.dtsi | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > > index 4ec9df78f205..d2040019e9c7 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > > @@ -319,6 +319,7 @@ flexcan1: can@443a0000 {
> > >  				assigned-clock-parents = <&clk
> > IMX93_CLK_SYS_PLL_PFD1_DIV2>;
> > >  				assigned-clock-rates = <40000000>;
> > >  				fsl,clk-source = /bits/ 8 <0>;
> > > +				fsl,stop-mode = <&anomix_ns_gpr 0x14 0>;
> > 
> > I think there's a typo in the mainline imx93.dtsi. AFAICS it's supposed to be
> > "aonmix_ns_gpr", not "anomix_ns_gpr". But that's a different problem to
> > patch :)
> 
> Yes, this is a typo.
> > 
> > AFAICS, according to imx93, rev2 data sheet, offset 0x14 is 76.6.1.3 QCHANNEL
> > DISABLE (QCH_DIS) and bit 0 is "GPIO1". Are you sure this is the correct reg?
> > 
> 
> Imx93 A1 doc has some update, I double confirm with the internal doc and IC team, the setting is correct.
> I also test on imx93-9x9 qsb board, system can be wakeup by this setting.

Thanks for double checking.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux