On 11/07/2023 13:02, Kathiravan T wrote: > > On 7/10/2023 5:40 PM, Konrad Dybcio wrote: >> On 10.07.2023 13:37, Krzysztof Kozlowski wrote: >>> On 10/07/2023 12:54, Kathiravan T wrote: >>>> IPQ5019 SoC is not available in production. Lets drop it. >>>> >>>> Signed-off-by: Kathiravan T <quic_kathirav@xxxxxxxxxxx> >>>> --- >>>> include/dt-bindings/arm/qcom,ids.h | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h >>>> index bcbe9ee2cdaf..179dd56b2d95 100644 >>>> --- a/include/dt-bindings/arm/qcom,ids.h >>>> +++ b/include/dt-bindings/arm/qcom,ids.h >>>> @@ -250,7 +250,6 @@ >>>> #define QCOM_ID_QRU1000 539 >>>> #define QCOM_ID_QDU1000 545 >>>> #define QCOM_ID_QDU1010 587 >>>> -#define QCOM_ID_IPQ5019 569 >>> What about users of this binding? What's the impact on them? When did >>> the SoC become obsolete and unsupported by Qualcomm? Remember that >>> ceasing a production does not mean that magically all users of a product >>> disappear... >> This + from my experience, SOCID entries are set in stone and freed >> indices are never reclaimed > > > This SKU is planned but never productized. That's why I removed it. If you mean this was never produced, then yes, it can be removed and your commit msg should be a bit more precise about it. Best regards, Krzysztof