On Fri, Jun 16, 2023 at 11:26:18AM +0530, Tushar Nimkar wrote: > > Thanks for review Sundeep, > > On 6/15/2023 2:26 PM, Sudeep Holla wrote: > > On Thu, Jun 08, 2023 at 02:25:42PM +0530, Tushar Nimkar wrote: > > > + idle-state-disabled: > > > + description: | > > > + If present the idle state stays disabled. It can be enabled back from > > > + shell using below command. > > > + echo N > /sys/devices/system/cpu/cpuX/cpuidle/stateX/disable > > > + type: boolean > > > + > > > > This is clearly a policy and not a hardware or firmware feature to expose > > in the device tree. So NACK, why can't you load it modules if you don't want > > idle states in the boot. > > > Attempt of making cpuidle governors to modular was rejected in past [2] > OK try command line approach to disable all states(you can't get partial on/off in that case). I don't think the build config is of any use as we end up enabling it which will affect other platforms. > [2] https://lore.kernel.org/lkml/1637830481-21709-1-git-send-email-quic_mkshah@xxxxxxxxxxx/#t > > > It is same as choosing any default governor or performance states, will you > > add those next ? It is simply policy not a feature/property to be exposed > > in the device tree. > > The above still holds, so still NACK. It is a policy and not a hardware/firmware property or feature. -- Regards, Sudeep
