Re: [PATCH 1/2] dt-bindings: arm: idle-states: Add idle-state-disabled property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Thanks for review Sundeep,

On 6/15/2023 2:26 PM, Sudeep Holla wrote:
On Thu, Jun 08, 2023 at 02:25:42PM +0530, Tushar Nimkar wrote:
+      idle-state-disabled:
+        description: |
+          If present the idle state stays disabled. It can be enabled back from
+          shell using below command.
+          echo N > /sys/devices/system/cpu/cpuX/cpuidle/stateX/disable
+        type: boolean
+

This is clearly a policy and not a hardware or firmware feature to expose
in the device tree. So NACK, why can't you load it modules if you don't want
idle states in the boot.

Attempt of making cpuidle governors to modular was rejected in past [2]

[2] https://lore.kernel.org/lkml/1637830481-21709-1-git-send-email-quic_mkshah@xxxxxxxxxxx/#t

It is same as choosing any default governor or performance states, will you
add those next ? It is simply policy not a feature/property to be exposed
in the device tree.

--
Regards,
Sudeep

Thanks,
Tushar



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux