On Thu, Jun 15, 2023 at 07:29:36PM +0100, Lucas Tanure wrote:
> Add serial bindings support menson T7 SoC family.
>
> Signed-off-by: Lucas Tanure <tanure@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> index 01ec45b3b406..01b01f8840ea 100644
> --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
> @@ -46,6 +46,7 @@ properties:
> - amlogic,meson8b-uart
> - amlogic,meson-gx-uart
> - amlogic,meson-s4-uart
> + - amlogic,meson-t7-uart
| diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
| index 2501db5a7aaf..0208f9a6ba7e 100644
| --- a/drivers/tty/serial/meson_uart.c
| +++ b/drivers/tty/serial/meson_uart.c
| @@ -796,6 +796,10 @@ static const struct of_device_id meson_uart_dt_match[] = {
| .compatible = "amlogic,meson-s4-uart",
| .data = (void *)&meson_g12a_uart_data,
| },
| + {
| + .compatible = "amlogic,meson-t7-uart",
| + .data = (void *)&meson_g12a_uart_data,
| + },
| { /* sentinel */ },
| };
| MODULE_DEVICE_TABLE(of, meson_uart_dt_match);
You're adding another element to this enum, but the driver change
implies compatibility with the s4 uart. Should you not set this up with
fallback compatibles?
Cheers,
Conor.
> - description: Everything-Else power domain UART controller on G12A SoCs
> items:
> - const: amlogic,meson-g12a-uart
> --
> 2.41.0
>
Attachment:
signature.asc
Description: PGP signature
