On Wed, Jun 14, 2023 at 1:43 PM Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx> wrote: > > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > Sent: Wednesday, June 14, 2023 5:12 PM ... > > > + /* select external voltage reference source for the ADC */ > > > + ret = max14001_reg_update(st, MAX14001_CFG, > > > + MAX14001_CFG_EXRF, 1); > > > + > > > + ret = regulator_get_voltage(vref); > > > + if (ret < 0) > > > + return dev_err_probe(dev, ret, > > > + "Failed to get vref\n"); > > > > Is it important to choose the external reference source _before_ getting the > > voltage of the regulator? If not, I would swap these calls, otherwise the > > comment is needed to explain why the sequence is important in the way it's > > written. > > It is not important. These calls can be swap without any issues. If you send a new version, please swap, otherwise I hope Jonathan can do it when applying. -- With Best Regards, Andy Shevchenko
