On 08/06/2023 15:01, Cong Yang wrote: > The ili9882t touch screen chip same as Elan eKTH6915 controller > has a reset gpio. The difference is that ili9882t needs to use > vccio-supply instead of vcc33-supply. Doug's series[1] allows panels > and touchscreens to power on/off together, let's add a phandle for this. > > [1]: https://lore.kernel.org/r/20230607215224.2067679-1-dianders@xxxxxxxxxxxx > > Signed-off-by: Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> > --- > .../bindings/input/ilitek,ili9882t.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml > > diff --git a/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml > new file mode 100644 > index 000000000000..89584264d6a2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/ilitek,ili9882t.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ilitek ili9882t touchscreen controller > + > +maintainers: > + - Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> This usually should not be subsystem maintainer. > + > +description: > + Supports the Ilitek ili9882t touchscreen controller. > + This touchscreen controller uses the i2c-hid protocol with a reset GPIO. > + > +allOf: > + - $ref: /schemas/input/touchscreen/touchscreen.yaml# > + > +properties: > + compatible: > + const: ilitek,ili9882t > + > + reg: > + const: 0x41 > + > + interrupts: > + maxItems: 1 > + > + panel: true > + > + reset-gpios: > + maxItems: 1 > + description: Reset GPIO. > + > + Just one blank line. > + vccio-supply: > + description: The 1.8V supply to the touchscreen. > + > +required: > + - compatible > + - reg > + - interrupts > + - vccio-supply > + > +additionalProperties: false Why do you disallow all properties from toouchscreen.yaml? Aren't they applicable? Best regards, Krzysztof