Hi, On Thu, Jun 8, 2023 at 6:02 AM Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/ilitek,ili9882t.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ilitek ili9882t touchscreen controller > + > +maintainers: > + - Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> Has Dmitry agreed to be the maintainer here? Traditionally when adding a new file one lists themselves. > +description: > + Supports the Ilitek ili9882t touchscreen controller. > + This touchscreen controller uses the i2c-hid protocol with a reset GPIO. > + > +allOf: > + - $ref: /schemas/input/touchscreen/touchscreen.yaml# > + > +properties: > + compatible: > + const: ilitek,ili9882t > + > + reg: > + const: 0x41 > + > + interrupts: > + maxItems: 1 > + > + panel: true > + > + reset-gpios: > + maxItems: 1 > + description: Reset GPIO. > + > + > + vccio-supply: > + description: The 1.8V supply to the touchscreen. Why two blank lines between reset-gpios and vccio-supply? > +required: > + - compatible > + - reg > + - interrupts > + - vccio-supply I think you want "panel" as a required property too, right? > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + touchscreen: touchscreen@41 { > + compatible = "ilitek,ili9882t"; > + reg = <0x41>; > + > + interrupt-parent = <&pio>; > + interrupts = <12 IRQ_TYPE_LEVEL_LOW>; > + > + reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>; > + vccio-supply = <&mt6366_vio18_reg>; ...and "panel" would also need to go in the above example.
