On Wed, 31 May 2023, Jakob Hauser wrote: > Dear all, > > On 15.05.23 22:57, Jakob Hauser wrote: > > This patchset adds the charger driver "rt5033-charger". It is part of the > > multifunction device rt5033. The patchset is based on an older version by > > Beomho Seo of March 2015. For more information on the history and setup of > > the patchset see the cover sheet of version v1, there is a link further down > > below the changelog. > > > > RESEND: Sorry for spamming. The first try of sending v6 got interrupted and > > was split into two threads on the lore list. Therefore sending it again. > > > > Changes in v6: > > - Patch 5: In function rt5033_charger_probe() after > > calling rt5033_charger_dt_init() replaced the return value from "-ENODEV" > > to "PTR_ERR(charger->chg)", as suggested by Christophe. > > - Patch 9: Changed the patch from adding "power-supplies: true" to replacing > > "additionalProperties: false" by "unevaluatedProperties: false", as > > suggested by Krzysztof. > > > > v1: https://lore.kernel.org/linux-pm/cover.1677620677.git.jahau@xxxxxxxxxxxxxx/T/#t > > v2: https://lore.kernel.org/linux-pm/cover.1681646904.git.jahau@xxxxxxxxxxxxxx/T/#t > > v3: https://lore.kernel.org/linux-pm/cover.1682636929.git.jahau@xxxxxxxxxxxxxx/T/#t > > v4: https://lore.kernel.org/linux-pm/20230506155435.3005-1-jahau@xxxxxxxxxxxxxx/T/#t > > v5: https://lore.kernel.org/linux-pm/20230514123130.41172-1-jahau@xxxxxxxxxxxxxx/T/#t > > > > The result of the patchset v6 can be seen at: > > https://github.com/Jakko3/linux/blob/rt5033-charger_v6/drivers/power/supply/rt5033_charger.c > > What's missing on this patchset? I'm not familiar with the procedures. If > all patches need ack's, then the ones for mfd (patches 2 & 4) and for > dt-bindings (patch 10) are missing. You're waiting on me. I will apply all of the patches and submit a PR. You're in the queue - please stand-by. > Link to the current patchset v6: > - on lore: https://lore.kernel.org/linux-pm/cover.1684182964.git.jahau@xxxxxxxxxxxxxx/T/#t > - on patchwork: https://patchwork.kernel.org/project/linux-pm/list/?series=747771&state=%2A&archive=both > > > Jakob Hauser (9): > > mfd: rt5033: Fix chip revision readout > > mfd: rt5033: Fix STAT_MASK, HZ_MASK and AICR defines > > mfd: rt5033: Apply preparatory changes before adding rt5033-charger > > driver > > power: supply: rt5033_charger: Add RT5033 charger device driver > > power: supply: rt5033_charger: Add cable detection and USB OTG supply > > power: supply: rt5033_battery: Move struct rt5033_battery to battery > > driver > > power: supply: rt5033_battery: Adopt status property from charger > > dt-bindings: power: supply: rt5033-battery: Apply > > unevaluatedProperties > > dt-bindings: Add rt5033 mfd, regulator and charger > > > > Stephan Gerhold (1): > > mfd: rt5033: Drop rt5033-battery sub-device > > > > .../bindings/mfd/richtek,rt5033.yaml | 138 ++++ > > .../power/supply/richtek,rt5033-battery.yaml | 2 +- > > .../power/supply/richtek,rt5033-charger.yaml | 65 ++ > > drivers/mfd/rt5033.c | 8 +- > > drivers/power/supply/Kconfig | 8 + > > drivers/power/supply/Makefile | 1 + > > drivers/power/supply/rt5033_battery.c | 38 +- > > drivers/power/supply/rt5033_charger.c | 744 ++++++++++++++++++ > > include/linux/mfd/rt5033-private.h | 64 +- > > include/linux/mfd/rt5033.h | 24 - > > 10 files changed, 1034 insertions(+), 58 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/mfd/richtek,rt5033.yaml > > create mode 100644 Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml > > create mode 100644 drivers/power/supply/rt5033_charger.c > > Kind regards, > Jakob -- Lee Jones [李琼斯]