On Wed, May 17, 2023 at 08:48:04AM +0000, Claudiu.Beznea@xxxxxxxxxxxxx wrote: > On 16.05.2023 15:58, Claudiu Beznea - M18063 wrote: > > Hi, Conor, > > > > On 16.05.2023 15:00, Conor Dooley wrote: > >> Hey Claudiu, > >> > >> On Tue, May 16, 2023 at 08:18:33AM +0300, Claudiu Beznea wrote: > >>> Convert Atmel PMC documentation to yaml. Along with it clock names > >>> were adapted according to the current available device trees as > >>> different controller versions accept different clock (some of them > >>> have 3 clocks as input, some has 2 clocks as inputs and some with 2 > >>> input clocks uses different clock names). > >>> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > >>> new file mode 100644 > >>> index 000000000000..e5f514bc4bf7 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > >>> @@ -0,0 +1,153 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/clock/atmel,at91rm9200-pmc.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Atmel Power Management Controller (PMC) > >>> + > >>> +maintainers: > >>> + - Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> > >>> + > >>> +description: > >>> + The power management controller optimizes power consumption by controlling all > >>> + system and user peripheral clocks. The PMC enables/disables the clock inputs > >>> + to many of the peripherals and to the processor. > >>> + > >>> +properties: > >>> + compatible: > >>> + oneOf: > >>> + - items: > >>> + - const: atmel,at91sam9g20-pmc > >>> + - const: atmel,at91sam9260-pmc > >>> + - const: syscon > >>> + - items: > >>> + - enum: > >>> + - atmel,at91sam9g15-pmc > >>> + - atmel,at91sam9g25-pmc > >>> + - atmel,at91sam9g35-pmc > >>> + - atmel,at91sam9x25-pmc > >>> + - atmel,at91sam9x35-pmc > >>> + - const: atmel,at91sam9x5-pmc > >> Yet another combinations question for you... > >> With this binding the following is not possible: > >> > >> "atmel,at91sam9x5-pmc", "syscon" > >> > >> Is that intended? > > > > No, I've just missed it. Same for the above. I'll have a new round and fix it. > > Though... shouldn't this have been detected by make dtbs_check? Only if there actually exists a dtb containing compatible = "atmel,at91sam9x5-pmc", "syscon"; that is enabled by the config that you are building with. From taking a quick look: git grep "\"atmel,at91sam9x5-pmc\", \"syscon\"" arch/arm/boot/dts/at91sam9g15.dtsi: compatible = "atmel,at91sam9g15-pmc", "atmel,at91sam9x5-pmc", "syscon"; arch/arm/boot/dts/at91sam9g25.dtsi: compatible = "atmel,at91sam9g25-pmc", "atmel,at91sam9x5-pmc", "syscon"; arch/arm/boot/dts/at91sam9g35.dtsi: compatible = "atmel,at91sam9g35-pmc", "atmel,at91sam9x5-pmc", "syscon"; arch/arm/boot/dts/at91sam9x25.dtsi: compatible = "atmel,at91sam9x25-pmc", "atmel,at91sam9x5-pmc", "syscon"; arch/arm/boot/dts/at91sam9x35.dtsi: compatible = "atmel,at91sam9x35-pmc", "atmel,at91sam9x5-pmc", "syscon"; arch/arm/boot/dts/at91sam9x5.dtsi: compatible = "atmel,at91sam9x5-pmc", "syscon"; There's only actually one place where you have this combination & it seems to get overridden by all of the more specific dtsi files that include at91sam9x5.dtsi. Hope that helps, Conor.
Attachment:
signature.asc
Description: PGP signature
