On 16.05.2023 15:58, Claudiu Beznea - M18063 wrote: > Hi, Conor, > > On 16.05.2023 15:00, Conor Dooley wrote: >> Hey Claudiu, >> >> On Tue, May 16, 2023 at 08:18:33AM +0300, Claudiu Beznea wrote: >>> Convert Atmel PMC documentation to yaml. Along with it clock names >>> were adapted according to the current available device trees as >>> different controller versions accept different clock (some of them >>> have 3 clocks as input, some has 2 clocks as inputs and some with 2 >>> input clocks uses different clock names). >>> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml >>> new file mode 100644 >>> index 000000000000..e5f514bc4bf7 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml >>> @@ -0,0 +1,153 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/clock/atmel,at91rm9200-pmc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Atmel Power Management Controller (PMC) >>> + >>> +maintainers: >>> + - Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx> >>> + >>> +description: >>> + The power management controller optimizes power consumption by controlling all >>> + system and user peripheral clocks. The PMC enables/disables the clock inputs >>> + to many of the peripherals and to the processor. >>> + >>> +properties: >>> + compatible: >>> + oneOf: >>> + - items: >>> + - const: atmel,at91sam9g20-pmc >>> + - const: atmel,at91sam9260-pmc >>> + - const: syscon >>> + - items: >>> + - enum: >>> + - atmel,at91sam9g15-pmc >>> + - atmel,at91sam9g25-pmc >>> + - atmel,at91sam9g35-pmc >>> + - atmel,at91sam9x25-pmc >>> + - atmel,at91sam9x35-pmc >>> + - const: atmel,at91sam9x5-pmc >> Yet another combinations question for you... >> With this binding the following is not possible: >> >> "atmel,at91sam9x5-pmc", "syscon" >> >> Is that intended? > > No, I've just missed it. Same for the above. I'll have a new round and fix it. Though... shouldn't this have been detected by make dtbs_check? > > Thanks for having a look at this, > Claudiu > >> I notice "atmel,at91sam9260-pmc" is able to appear as: >> >> "atmel,at91sam9260-pmc", "syscon" >> >> So the inconsistency stands out. >> >>> + - const: syscon >>> + - items: >>> + - enum: >>> + - atmel,at91rm9200-pmc >>> + - atmel,at91sam9260-pmc >>> + - atmel,at91sam9g45-pmc >>> + - atmel,at91sam9n12-pmc >>> + - atmel,at91sam9rl-pmc >>> + - atmel,sama5d2-pmc >>> + - atmel,sama5d3-pmc >>> + - atmel,sama5d4-pmc >>> + - microchip,sam9x60-pmc >>> + - microchip,sama7g5-pmc >>> + - const: syscon >> Otherwise, this looks grand to me. >> >> Cheers, >> Conor. >
