Hi Krzysztof Kozlowski, > Subject: RE: [PATCH v3] dt-bindings: rtc: isl1208: Convert to json-schema > > Hi Krzysztof Kozlowski, > > Thanks for the feedback. > > > Subject: Re: [PATCH v3] dt-bindings: rtc: isl1208: Convert to > > json-schema > > > > On 05/05/2023 11:17, Biju Das wrote: > > > Convert the isl1208 RTC device tree binding documentation to json- > schema. > > > > > > Update the example to match reality. > > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > > Thank you for your patch. There is something to discuss/improve. > > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > > +--- > > > +$id: > > > + > > > +title: Intersil ISL1209/19 I2C RTC/Alarm chip with event in > > > + > > > +maintainers: > > > + - Trent Piepho <tpiepho@xxxxxxxxx> > > > + > > > +description: | > > > > Do not need '|' unless you need to preserve formatting. > > OK, will remove it. I get an error after removing '|'. ./Documentation/devicetree/bindings/rtc/isil,isl1208.yaml:13:42: [error] missing starting space in comment (comments) ./Documentation/devicetree/bindings/rtc/isil,isl1208.yaml:14:3: [error] syntax error: expected <block end>, but found '<scalar>' (syntax) Which is fixed by replacing the text, #EVDET->EVDET. So I will be updating this as well in the next version. Cheers, Biju > > > > > > + ISL12X9 have additional pins EVIN and #EVDET for tamper > > > + detection, while the > > > + ISL1208 and ISL1218 do not. > > > + > > > +properties: > > > + compatible: > > > + oneOf: > > > > It's not oneOf, but only enum. > > OK. Will fix this in next version. > > Cheers, > Biju > > > > > > + - enum: > > > + - isil,isl1208 > > > + - isil,isl1209 > > > + - isil,isl1218 > > > + - isil,isl1219 > > > + > > > > With above fixed: > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > > Best regards, > > Krzysztof
