On 08/05/2023 15:15, Bharat Bhushan wrote: > Add binding documentation for the Marvell GTI system > watchdog driver. > > Signed-off-by: Bharat Bhushan <bbhushan2@xxxxxxxxxxx> > --- > v7: > - Corrected compatible to have soc name > - Converted marvell,wdt-timer-index to optional > > .../watchdog/marvell,octeontx2-wdt.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml b/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml > new file mode 100644 > index 000000000000..72951b10f1f3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/marvell,octeontx2-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell Global Timer (GTI) system watchdog > + > +allOf: > + - $ref: watchdog.yaml# Put allOf after maintainers:. > + > +maintainers: > + - Bharat Bhushan <bbhushan2@xxxxxxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - const: marvell,octeontx2-wdt Why is this alone? Judging by the enum below, octeontx2 is not specific. > + - items: > + - enum: > + - marvell,octeontx2-95xx-wdt > + - marvell,octeontx2-96xx-wdt > + - marvell,octeontx2-98xx-wdt We don't allow wildcards in general > + - const: marvell,octeontx2-wdt > + - const: marvell,cn10k-wdt Same question - why is this alone? Second question - it should be rather part of enum with the first one if accepted. > + - items: > + - enum: > + - marvell,cn10kx-wdt > + - marvell,cnf10kx-wdt > + - const: marvell,cn10k-wdt > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 1 maxItems instead. You see it is different than above properties? > + > + clock-names: > + minItems: 1 Need to define names. Best regards, Krzysztof
