Re: [PATCH v2 3/5] iio: mlx90614: Drop unused register macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I was retaining these macros in case future development would need
them. Since 90614 already has successor in 90632, I can agree to their
removal.

Acked-by: Crt Mori <cmo@xxxxxxxxxxx>

On Sun, 7 May 2023 at 20:47, Marek Vasut <marex@xxxxxxx> wrote:
>
> To simplify addition of support for new parts, drop unused register macros.
> No functional change.
>
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> ---
> Cc: Crt Mori <cmo@xxxxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: Marek Vasut <marex@xxxxxxx>
> Cc: Peter Meerwald <pmeerw@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-iio@xxxxxxxxxxxxxxx
> ---
> V2: New patch
> ---
>  drivers/iio/temperature/mlx90614.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/iio/temperature/mlx90614.c b/drivers/iio/temperature/mlx90614.c
> index bd92b24918253..b0f69a7b05abc 100644
> --- a/drivers/iio/temperature/mlx90614.c
> +++ b/drivers/iio/temperature/mlx90614.c
> @@ -35,8 +35,6 @@
>  #define MLX90614_OP_SLEEP      0xff
>
>  /* RAM offsets with 16-bit data, MSB first */
> -#define MLX90614_RAW1  (MLX90614_OP_RAM | 0x04) /* raw data IR channel 1 */
> -#define MLX90614_RAW2  (MLX90614_OP_RAM | 0x05) /* raw data IR channel 2 */
>  #define MLX90614_TA    (MLX90614_OP_RAM | 0x06) /* ambient temperature */
>  #define MLX90614_TOBJ1 (MLX90614_OP_RAM | 0x07) /* object 1 temperature */
>  #define MLX90614_TOBJ2 (MLX90614_OP_RAM | 0x08) /* object 2 temperature */
> @@ -52,8 +50,6 @@
>  #define MLX90614_CONFIG_DUAL_MASK (1 << MLX90614_CONFIG_DUAL_SHIFT)
>  #define MLX90614_CONFIG_FIR_SHIFT 8 /* FIR coefficient */
>  #define MLX90614_CONFIG_FIR_MASK (0x7 << MLX90614_CONFIG_FIR_SHIFT)
> -#define MLX90614_CONFIG_GAIN_SHIFT 11 /* gain */
> -#define MLX90614_CONFIG_GAIN_MASK (0x7 << MLX90614_CONFIG_GAIN_SHIFT)
>
>  /* Timings (in ms) */
>  #define MLX90614_TIMING_EEPROM 20 /* time for EEPROM write/erase to complete */
> --
> 2.39.2
>



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux