Re: [PATCH v6 12/13] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/05/2023 12:47, Konrad Dybcio wrote:
         connector {
                 compatible = "usb-c-connector";
                 ports {
                         #address-cells = <1>;
                         #size-cells = <0>;

                         port@0 {
                                 reg = <0>;
                                 pm8150b_role_switch_out: endpoint {
                                         remote-endpoint = <&dwc3_role_switch_in>;
                                 };
                         };
====

Hmm, I'm actually recoiling from doing this now that I look at it.

- Every other implementation defines the connector in the platfrom
  dts not the core dtsi

- The connector would have to be named something like
  pm8150b_type_connector which is not consistent with the
  rest of the Type-C connector namespace


Yes it can be done that the connector with the ports can be defined in the pm8150b dtsi but TBH I think it is more confusing that way and not consistent with other implementations.

I'm citing prior art here I just think this is nicer/easier to follow

- arch/arm64/boot/dts/qcom/sc8280xp.dtsi
- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts

So for now

https://imgflip.com/i/7kw6ck

---
bod



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux