On 1.05.2023 14:11, Bryan O'Donoghue wrote:
> Switch on usb-role-switching for usb_1 via TCPM. We need to declare
> usb-role-switch in &usb_1 and associate with the remote-endpoint in TCPM
> which provides the necessary signal.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 19 ++++++++++++++++++-
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 4 ++++
> 2 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index 1e0b6fd59abc9..b5cc45358a474 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -1273,7 +1273,13 @@ &usb_1 {
> };
>
> &usb_1_dwc3 {
> - dr_mode = "peripheral";
> + dr_mode = "otg";
> + usb-role-switch;
> + port {
> + dwc3_role_switch_in: endpoint {
Any reason you're redefining it? You can just do
&dwc3_role_switch_in {
remote-endpoint = <&pm8150b_role_switch_out>;
};
> + remote-endpoint = <&pm8150b_role_switch_out>;
> + };
> + };
> };
>
> &usb_1_hsphy {
> @@ -1359,5 +1365,16 @@ connector {
> PDO_FIXED_DUAL_ROLE |
> PDO_FIXED_USB_COMM |
> PDO_FIXED_DATA_SWAP)>;
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + pm8150b_role_switch_out: endpoint {
Similarly to the QMPPHY, the port definition can be moved to
the common node in the SoC DTSI
Konrad
> + remote-endpoint = <&dwc3_role_switch_in>;
> + };
> + };
> + };
> };
> };
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index af16d3ba76b8e..af988328db6b9 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -3740,6 +3740,10 @@ usb_1_dwc3: usb@a600000 {
> snps,dis_enblslpm_quirk;
> phys = <&usb_1_hsphy>, <&usb_1_ssphy>;
> phy-names = "usb2-phy", "usb3-phy";
> +
> + port {
> + dwc3_role_switch_in: endpoint {};
> + };
> };
> };
>
