Re: [PATCH v2 3/6] spi: sun6i: add quirk for in-controller clock divider

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 3/6] spi: sun6i: add quirk for in-controller clock divider
From: Maxim Kiselev <bigunclemax@xxxxxxxxx>
Date: Sun, 7 May 2023 02:34:24 +0300
Cc: Icenowy Zheng <icenowy@xxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Chen-Yu Tsai <wens@xxxxxxxx>, Jernej Skrabec <jernej.skrabec@xxxxxxxxx>, Samuel Holland <samuel@xxxxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>, Heiko Stuebner <heiko.stuebner@xxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, linux-spi@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-sunxi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20230506225848.3278d7ab@slackpad.lan>

> Don't we need to set tfr->effective_speed_hz to the actually programmed
> clock rate here?

Yes, we should. Also we need to configure SPI sample mode by setting
SDM and SDC bits in the SPI_TCR register.

Please check a new version of this patch.
https://lore.kernel.org/linux-arm-kernel/20230506232616.1792109-5-bigunclemax@xxxxxxxxx/

References:
- [PATCH v2 0/6] Allwinner R329/D1/R528/T113s SPI support
  - From: Maksim Kiselev
- [PATCH v2 3/6] spi: sun6i: add quirk for in-controller clock divider
  - From: Maksim Kiselev
- Re: [PATCH v2 3/6] spi: sun6i: add quirk for in-controller clock divider
  - From: Andre Przywara

Prev by Date: [PATCH v3 5/5] riscv: dts: allwinner: d1: Add SPI controllers node
Next by Date: Re: [PATCH v3 1/2] gnss: ubx: customize serial device open to set U-Blox Zed-F9P baud
Previous by thread: Re: [PATCH v2 3/6] spi: sun6i: add quirk for in-controller clock divider
Next by thread: [PATCH v2 4/6] spi: sun6i: add support for R329 SPI controllers
Index(es):
- Date
- Thread

[Index of Archives] [Device Tree Compilter] [Device Tree Spec] [Linux Driver Backports] [Video for Linux] [Linux USB Devel] [Linux PCI Devel] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [XFree86] [Yosemite Backpacking]