On 06/05/2023 04:58, Peng Fan wrote: >> Subject: Re: [PATCH 1/2] dt-bindings: nvmem: add binding doc for i.MX >> OCOTP/ELE >> >> On 05/05/2023 14:01, Krzysztof Kozlowski wrote: >>> On 05/05/2023 11:17, Peng Fan (OSS) wrote: >>>> From: Peng Fan <peng.fan@xxxxxxx> >>>> >>>> There are two parts of i.MX93 OCOTP, with 1st part Fuse shadow >>>> block(fsb), 2nd part managed by ELE firmware. This binding doc supports >> both. >>> >>> Subject: drop second/last, redundant "binding doc for". The >>> "dt-bindings" prefix is already stating that these are bindings and >>> documentation. >>> >>>> >>>> Signed-off-by: Peng Fan <peng.fan@xxxxxxx> >>>> --- >>>> .../bindings/nvmem/imx-ocotp-ele.yaml | 65 +++++++++++++++++++ >>>> 1 file changed, 65 insertions(+) >>>> create mode 100644 >>>> Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >>>> b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >>>> new file mode 100644 >>>> index 000000000000..024594a2bcb4 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >>> >>> Filename matching compatible style. fsl,imx93-ocotp.yaml >>> >>> >>>> @@ -0,0 +1,65 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >>>> +--- >>>> +$id: >>>> >> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdev >>>> +icetree.org%2Fschemas%2Fnvmem%2Fimx-ocotp- >> ele.yaml%23&data=05%7C01%7 >>>> >> +Cpeng.fan%40nxp.com%7Cd779f2b1abe94a0d493208db4d618fd9%7C686e >> a1d3bc2 >>>> >> +b4c6fa92cd99c5c301635%7C0%7C0%7C638188853636582816%7CUnknown >> %7CTWFpb >>>> >> +GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV >> CI6M >>>> >> +n0%3D%7C3000%7C%7C%7C&sdata=2uIFOmUqlbgPIRasl%2FyO0CdZAFPhV >> 2qpHnhwKB >>>> +OZ008%3D&reserved=0 >>>> +$schema: >>>> >> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdev >>>> +icetree.org%2Fmeta- >> schemas%2Fcore.yaml%23&data=05%7C01%7Cpeng.fan%40 >>>> >> +nxp.com%7Cd779f2b1abe94a0d493208db4d618fd9%7C686ea1d3bc2b4c6f >> a92cd99 >>>> >> +c5c301635%7C0%7C0%7C638188853636582816%7CUnknown%7CTWFpbG >> Zsb3d8eyJWI >>>> >> +joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 >> C3000 >>>> >> +%7C%7C%7C&sdata=iKJpzjsi7TuqxDim7sUjHmwFR1eK9hFNp2ygMap9bq8% >> 3D&reser >>>> +ved=0 >>>> + >>>> +title: NXP i.MX9 On-Chip OTP Controller (OCOTP) >>>> + >>>> +maintainers: >>>> + - Peng Fan <peng.fan@xxxxxxx> >>>> + >>>> +allOf: >>>> + - $ref: nvmem.yaml# >>>> + >>>> +properties: >>>> + compatible: >>>> + oneOf: >>>> + - items: >>>> + - const: fsl,imx93-ocotp-fsb >>>> + - const: syscon >>>> + - items: >>>> + - const: fsl,imx93-ocotp-ele >>>> + >> >> Actually this is the same as existing bindings. Just squash it. > > You mean add the compatible to imx-ocotp.yaml? I missed this file, I was thinking about mxs, but sure, can go to imx. All of them are the same... > >> >> However I wonder - why this is syscon? > > Someone may wanna to use syscon_to_regmap? > I just follow imx-ocotp.yaml. That's not a good reason to add syscon. Drop it. Best regards, Krzysztof
