On 05/05/2023 14:01, Krzysztof Kozlowski wrote: > On 05/05/2023 11:17, Peng Fan (OSS) wrote: >> From: Peng Fan <peng.fan@xxxxxxx> >> >> There are two parts of i.MX93 OCOTP, with 1st part Fuse shadow block(fsb), >> 2nd part managed by ELE firmware. This binding doc supports both. > > Subject: drop second/last, redundant "binding doc for". The > "dt-bindings" prefix is already stating that these are bindings and > documentation. > >> >> Signed-off-by: Peng Fan <peng.fan@xxxxxxx> >> --- >> .../bindings/nvmem/imx-ocotp-ele.yaml | 65 +++++++++++++++++++ >> 1 file changed, 65 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >> >> diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >> new file mode 100644 >> index 000000000000..024594a2bcb4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml > > Filename matching compatible style. fsl,imx93-ocotp.yaml > > >> @@ -0,0 +1,65 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/nvmem/imx-ocotp-ele.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NXP i.MX9 On-Chip OTP Controller (OCOTP) >> + >> +maintainers: >> + - Peng Fan <peng.fan@xxxxxxx> >> + >> +allOf: >> + - $ref: nvmem.yaml# >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - const: fsl,imx93-ocotp-fsb >> + - const: syscon >> + - items: >> + - const: fsl,imx93-ocotp-ele >> + Actually this is the same as existing bindings. Just squash it. However I wonder - why this is syscon? Best regards, Krzysztof
