RE: [PATCH v2 1/1] dt-bindings: iio: imx8qxp-adc: add missing vref-supply

[Bough Chen <haibo.chen@xxxxxxx>]

> -----Original Message-----
> From: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> Sent: 2023年4月24日 17:23
> To: Cai Huoqing <cai.huoqing@xxxxxxxxx>; Bough Chen <haibo.chen@xxxxxxx>;
> Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>;
> Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>;
> Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; Fabio Estevam
> <festevam@xxxxxxxxx>
> Cc: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>; Pengutronix Kernel
> Team <kernel@xxxxxxxxxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>;
> linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> Subject: [PATCH v2 1/1] dt-bindings: iio: imx8qxp-adc: add missing vref-supply
> 
> Although this property is used right now for IIO_CHAN_INFO_SCALE, this ADC
> has two internal reference voltages, which the driver currently doesn't make use
> of.
> 
> Fixes: db73419d8c06 ("dt-bindings: iio: adc: Add binding documentation for NXP
> IMX8QXP ADC")
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>

Thanks! 
Reviewed-by: Haibo Chen <haibo.chen@xxxxxxx>

> ---
> Thanks for your inputs. This improved descritpion should make it clear that this
> property is only about the external reference voltage, not about the optional,
> internal voltages.
> 
> Changes in v2:
> * Improved commit message subject as suggested
> * Add hint about feature flag regarding multiple, internal, reference
>   voltages
> 
>  .../devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml       | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml
> b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml
> index 63369ba388e4..878e67054d7c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml
> @@ -39,6 +39,12 @@ properties:
>    power-domains:
>      maxItems: 1
> 
> +  vref-supply:
> +    description: |
> +      External ADC reference voltage supply on VREFH pad. If VERID[MVI] is
> +      set, there are additional, internal reference voltages selectable.
> +      VREFH1 is always from VREFH pad.
> +
>    "#io-channel-cells":
>      const: 1
> 
> @@ -72,6 +78,7 @@ examples:
>              assigned-clocks = <&clk IMX_SC_R_ADC_0>;
>              assigned-clock-rates = <24000000>;
>              power-domains = <&pd IMX_SC_R_ADC_0>;
> +            vref-supply = <&reg_1v8>;
>              #io-channel-cells = <1>;
>          };
>      };
> --
> 2.34.1