On Mon, 3 Apr 2023 at 15:57, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 03/04/2023 13:45, Dmitry Baryshkov wrote: > >> Konrad > >>>> + > >>>> #undef PMIC_SID > >>>> #undef PMIC_SID1 > >>>> #undef PMIC_LABEL > >>> > >>> Same comment as for previous patches - all undefs must be gone. > > > > This means that we can not include two copies of the same PMIC (which > > do have on both platforms). > > Consider spi15 and spi16: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sm8250.dtsi?h=v6.3-rc5&id=7e364e56293bb98cae1b55fd835f5991c4e96e7d#n1045 > > Do you see it written as #include "qcom-sm8250-spi.dtsi" with > parametrizing the reg/unit address, interrupts etc? > > No. Neither PMIC should be. It is not a special device. I think there should be balance. PMICs are complex structures. Possibly schema will help here once it is in a more enforced mode. -- With best wishes Dmitry
