Hi, On Thu, Mar 16, 2023 at 4:46 PM Tianling Shen <cnsztl@xxxxxxxxx> wrote: > > Hi Jonas, > > On Thu, Mar 16, 2023 at 3:37 PM Jonas Karlman <jonas@xxxxxxxxx> wrote: > > [...] > > > > Generic ethernet phy driver is not resetting the phy in the same way > > that snsp,reset-gpio does, please see top two commits at [1]. > > > > I have been meaning to send that out as an RFC but I got stuck in a > > u-boot rabbit hole, and I also do not know what the correct way to fix > > this would be, so I played with both device tree and code changes. > > Will prioritize this and send out a RFC later today. > > > > [1] https://github.com/Kwiboo/linux-rockchip/commits/rk3568-eth-phy-reset > > Thanks for the hint! I will test your patches tonight. I'm currently playing your patches at https://github.com/1715173329/imoutowrt/commits/master-rockchip-mdio I applied commit 8597fcfa0c5c792dabb44a2db7b283c56c99ec6a to NanoPi R5S, it worked perfectly. However, with commit c338ed260bfd87277c41aa0290f1f2aad8d629b1 + moving reset properties into the phy node, the driver still failed to lookup phy. I'm not sure if I missed / misunderstood anything. Thanks, Tianling. [...]
