On 15/03/2023 16:52, Nishanth Menon wrote: > For convenience (less code duplication), the pin controller pin > configuration register values were defined in the bindings header. > These are not some IDs or other abstraction layer but raw numbers used > in the registers. > > These constants do not fit the purpose of bindings. They do not > provide any abstraction, any hardware and driver independent ID. In > fact, the Linux pinctrl-single driver actually do not use the bindings > header at all. > > All of the constants were moved already to headers local to DTS > (residing in DTS directory), so remove any references to the bindings > header and add a warning that it is deprecated. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Link: https://lore.kernel.org/linux-arm-kernel/71c7feff-4189-f12f-7353-bce41a61119d@xxxxxxxxxx/ > Signed-off-by: Nishanth Menon <nm@xxxxxx> > --- > New patch in V2 series and we expect to remove this header after a kernel > rev. > > include/dt-bindings/pinctrl/k3.h | 7 +++++++ > 1 file changed, 7 insertions(+) This should go to the same branch as DTS, so not pinctrl tree, to avoid warnings. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
