On 15/03/2023 16:52, Nishanth Menon wrote: > The DTS uses hardware register values directly in pin controller pin > configuration and not an abstraction of any form. > > These definitions were previously put in the bindings header to avoid > code duplication and to provide some context meaning (name), but they > do not fit the purpose of bindings. > > Store the constants in a header next to DTS and use them instead of > bindings. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Suggested-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Link: https://lore.kernel.org/all/c4d53e9c-dac0-8ccc-dc86-faada324beba@xxxxxxxxxx/ > Signed-off-by: Nishanth Menon <nm@xxxxxx> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof