On Thu, Mar 09, 2023 at 11:37:17PM +0100, Konrad Dybcio wrote:
>
> [...]
> = of_graph_get_remote_node(dsi->dev.of_node, 1, -1);
> >>>>> + if (!dsi1) {
> >>>>> + dev_err(dev, "cannot get secondary DSI node.\n");
> >>>>> + return -ENODEV;
> >>>>> + }
> >>>>> +
> >>>>> + dsi1_host = of_find_mipi_dsi_host_by_node(dsi1);
> >>>>> + of_node_put(dsi1);
> >>>> Shouldn't you put the reference only if it's found?
> >>> thanks for spot it.
> Apparently not.. please don't change this
OK
>
> Konrad
> >>>>
> >>>>> + if (!dsi1_host) {
> >>>>> + dev_err(dev, "cannot get secondary DSI host\n");
> >>>>> + return -EPROBE_DEFER;
> >>>> dev_err_probe, here and in neighbouring exit return paths?
> >>> Acked.
> >>>>
> >>>>
> >>>> Konrad
