On 08/03/2023 10:24, zhuyinbo wrote: >>>> That's an ABI break and commit msg does not explain it. >>> you meaning is that need add a explanation in commit msg that why >> You need good explanation to break the ABI. I don't understand the >> commit msg, but anyway I could not find there justification for ABI >> break. If you do not have good justification, don't break the ABI, > > The commit msg is the patch commit log, and I maybe not got it about > break the ABI. You said about "break the ABI" > > is whether is location issue about "LOONGSON2_BOOT_CLK"? if yes, the > LOONGSON2_BOOT_CLK was placed > > after LOONGSON2_PIX1_PLL that is due to their clock parent is same. > and I whether need add this explanation > > in patch commit log description? Unfortunately I do not understand single thing from this. Best regards, Krzysztof